Cleanup Spring Dependencies #1334
Open
+155
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
salaboy
reviewed
May 6, 2025
salaboy
requested changes
May 6, 2025
There was a problem hiding this comment.
@siri-varma I've left some comments .. I do recommend not having the springframework.version managed in this way.. it will make it really hard to maintain.
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
siri-varma
force-pushed
the
users/svegiraju/spring-pom-update
branch
from
40660c4 to
508148c
Compare
Signed-off-by: sirivarma <[email protected]>
|
@salaboy addressed all your comments. Thank you |
artur-ciocanu
requested changes
May 14, 2025
There was a problem hiding this comment.
@siri-varma the PR looks good, but could you please provide some details why this is needed so I have a better high level understanding.
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
siri-varma
force-pushed
the
users/svegiraju/spring-pom-update
branch
from
56c3570 to
94de244
Compare
siri-varma
commented
May 20, 2025
siri-varma
commented
May 20, 2025
siri-varma
commented
May 20, 2025
|
@artur-ciocanu / @salaboy / @dapr-java-sdk-reveiwers PR is ready to be reviewed. Thank you |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
============================================
+ Coverage 76.91% 78.17% +1.25%
- Complexity 1592 1831 +239
============================================
Files 145 223 +78
Lines 4843 5663 +820
Branches 562 601 +39
============================================
+ Hits 3725 4427 +702
- Misses 821 916 +95
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #940
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: